Re: [PEPr] Comment on HTML::HTML_Template

hi everyone! thanks all of you for your help! however let's analyse all of your points: a) yes, the name is a little bit general.. maybe i should consider another one b) and c) you are totally true, i'm going to write some fixes... i'm still working about it d) about constants i didn't underatand the problem.. i'll read something about however, i've checked out other's pear template engines, but i think that they are not totally complete (nothing against developer!) and so i wanted to improve with some new fresh code! i really do not think how could i improve existibg packages because of their differents with my own (that's why i'v choosen to write a new one!) however, thank you all anyway. i hope you're going to give me more suggestions in order to make my and pear code even better! j. Sent from my iPhone On Feb 1, 2010, at 0:04, "Alan Knowles" <alan@akbkhome.com> wrote: > > a) Naming > It's been discussed before, If you could provide an API, and write the > code to unify all the existing template engines in PEAR etc. then this > would be a suitable name, otherwise please pick a name > 'HTML_Template_Jacopo' or similar. > > (there was considerable interest in doing this a few years ago, but it > never saw the light of day... as unfortuntaly it's not a pretty > problem to > solve.) > > b) Escaping output. > Did not see that the engine was doing this.. - bit of a security hole, > > c) Include all - why include the compiler etc. when you may have > already > compiled the template. > > d) Constants - please use PHP5 constants, rather than poluting the > global > namespace. > > Last of all: > Think about why this is an improvement on the current offerings in > PEAR, > why you did not contribute to them rather than create a new one. > > -- > http://pear.php.net/pepr/pepr-proposal-show.php?id=626