Re: Re: New Net_Gearman work

Just btw, but please update the link to the external repo on the Net_Gearman's PEAR package homepage so people see that your "fork" is the current master. ;-) On Mon, Apr 5, 2010 at 3:06 PM, till <till@php.net> wrote: > Looking at the code now, currently I don't seem to be able to get any > callbacks to work. > > My jobs process though, but neither start, fail or complete are > called. The monitor however works (Net_Gearman_Worker::beginWork()). > > I've also added a bunch of things on github: > >  * some additional exceptions when attaching callbacks >  * "fixed" count() statements >  * made Net_Gearman_Job_Exception extend Net_Gearman_Exception >  * fixed up package.xml, and added @package_version@ to all files > > I'm sending a pull request now and keep looking - want to see if I can > fix the callbacks as they are essential to me. > > ... let me know what you think. > > Till > > On Mon, Apr 5, 2010 at 5:01 AM, Brian Moon <brian@moonspot.net> wrote: >> Sure, I will take whatever help you want to give. >> >> >> Brian. >> -------- >> http://brian.moonspot.net/ >> >> On 4/4/10 12:08 PM, till wrote: >>> >>> On Sun, Apr 4, 2010 at 6:49 AM, Brian Moon<brian@moonspot.net>  wrote: >>>>> >>>>> Hash a jobs unique id to always send it to the same server. Other >>>>> clients do this already. So, I think it is expected. getConnection() >>>>> needs to take an optional unique id from submitTask and do the hashing >>>>> there. A simple modulus hashing would be all that is needed. It would >>>>> need to detect downed gearmand servers and reselect ideally. >>>> >>>> An initial hashing is done in my fork. It does not detect and reselect, >>>> but >>>> the lib never did that. So, this is still better than it was before. >>>> >>>>> Convert the library over to the new IANA port. (this is partially done >>>>> in my github fork) >>>> >>>> Ok, all done in my fork. >>>> >>> >>> Sounds good. >>> >>> One thing I noticed with the last release is that the callbacks don't >>> always seem to run, or maybe not at all. I'll try to debug it more >>> next week. >>> >>> I was able to inject the monitor in beginWork(), but all my JOB_START, >>> JOB_FAIL and JOB_COMPLETE never trigger, no errors in the logs either. >>> >>> Regardless of the above, it would be great to get a new release out >>> asap, also a changelog detailing the changes (especially in regard to >>> BC) would be nice. >>> >>> Do you need help with the release process? >>> >>> Till >>> >>> Till >>> >> >> -- >> PEAR Development Mailing List (http://pear.php.net/) >> To unsubscribe, visit: http://www.php.net/unsub.php >> >> >