Re: HTTP_Request2 on pyrus - PEAR_Exception

I have, sorry it's uncommited, let me review and make sure then I'll commit.. On 4 June 2010 14:09, Christian Weiske <cweiske@cweiske.de> wrote: > Hi David, > > >> >> So what do we do now? Should HTTP_Request2 set a dep on PEAR, or >> >> should >> >> we move PEAR_Exception to an own package? I fear that more packages >> >> depend on PEAR_Exception implicitely. >> > >> > Well, the missing required dependency should be fixed immediately. >> > >> > But, for the future: >> > +1 on moving PEAR_Exception to its own package. >> > >> > and also, I think PEAR packages could start following the pear2 >> > exception policy [1], albeit adapted without namespaces. So: >> > <?php >> > interface HTTP_Request2_Exception{} >> > class HTTP_Request2_UnexpectedValueException extends >> > UnexpectedValueException implements HTTP_Request2_Exception {} >> > throw new HTTP_Request2_UnexpectedValueException(); >> > ?> >> > >> > Any thoughts on that? >> > >> > [1] >> > http://wiki.php.net/pear/rfc/pear2_exception_policy > >> I agree with that and will get on it tmrw > > Did you do anything in this regard? It's falling on my feet again. > > -- > Regards/Mit freundlichen Grüßen > Christian Weiske > > -=≡ Geeking around in the name of science since 1982 ≡=- > -- David Coallier