[PEPr] Comment on Networking::SNMP

From: Date: Sun, 30 Jan 2011 22:07:01 +0000
Subject: [PEPr] Comment on Networking::SNMP
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-54037@lists.php.net to get a copy of this message
1.) Use scope when declaring functions (public/private/protected) 2.) Making the package version 1.0 is premature. Usually packages start at 0.1 and go through some PAI refinement before reaching 1.0. When your package reaches 1.0 you must keep the API backwards compatible from that point on. 3.) Use class constants instead of define(). 4.) Directory structure should follow pear conventions. Your files are already named correctly but directory structure should reflect the filenames. The _ in filenames translates to / in the path. 5.) Run phpcs on the code. Lots of lines are longer than the maximum allowed length. 6.) sockets is a required extension for this package and should be listed in the package.xml file. 7.) Package description should give some idea of what SNMP is. I have no idea :) -- http://pear.php.net/pepr/pepr-proposal-show.php?id=581

« previous php.pear.dev (#54037) next »