[PEPr] Comment on Networking::SNMP

All looks great to me. I would personally amend point 13 a little bit. Dependency injection is great for unit testing, but can be a bit of an inconvenience when using the code in the real world. Instead, make it optional. //Bad function bar() { $bar = new Bar(); return $bar->doSomething(); } //Good function bar(Bar $bar = null) { if (!$bar instanceof Bar) { $bar = new Bar(); } return $bar->doSomething(); } //Good class X { function __construct($bar = null) { if (!$bar instanceof Bar) { $bar = new Bar(); } $this->bar = $bar; } function bar() { return $this->bar->doSomething(); } } -- http://pear.php.net/pepr/pepr-proposal-show.php?id=581