Re: [PEPr] +1 for Validate::Validate_IR

Thanks Damien i've fixed that bug. On Fri, Mar 18, 2011 at 5:10 AM, Damien Bezborodov < dbezborodov@internode.on.net> wrote: > > Damien Bezborodov (http://pear.php.net/user/dbezborodov) has voted +1 on > the proposal for Validate::Validate_IR. > > Proposal information: > http://pear.php.net/pepr/pepr-proposal-show.php?id=652 > Vote information: > > http://pear.php.net/pepr/pepr-vote-show.php?id=652&handle=dbezborodov > > This vote is conditional. The condition is: > > Looks alright to me. Not sure why it doesn't extend a Validate_Interface or > something, but that is out of scope for this review. > > > > I noticed one tiny bug: > > '/[0-9]{4}-?[0-9]{4}-?[0-9]{4}-?[0-9]{4}$/' > > is missing the start ^ > should be: > > '/^[0-9]{4}-?[0-9]{4}-?[0-9]{4}-?[0-9]{4}$/' > > test to prove that is broken would be nice before you fix it. > > > Also, the ssn could do with some comments explaining what's going on there. > Looks complicated. :) > > Good work, squire. > -- Regards Arash Hemmat