[PEPr] Comment on Validate::Validate_IR
| From: | Daniel O'Connor | Date: | Sat, 05 Feb 2011 06:28:52 +0000 |
| Subject: | [PEPr] Comment on Validate::Validate_IR | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-54055@lists.php.net to get a copy of this message | ||
Hey Arash, there's a few minor things (like creating a package.xml for
instance; rename to be .php not .phps); but since Validate_IR would be
packaged under the Validate family, I/other validate maintainers can simply
include it without going all the way through the PEPr process.
Can you clarify the licence? The package states BSD, but some text refers
to PHP 3.01.
Also; there's a bit of mixed tabs and whitespace - it's worth running
PHP_CodeSniffer over your code to pick up any problems.
--
http://pear.php.net/pepr/pepr-proposal-show.php?id=652