[PEPr] +1 for Validate::Validate_IR
| From: | Jesús Espino | Date: | Wed, 09 Mar 2011 10:56:11 +0000 |
| Subject: | [PEPr] +1 for Validate::Validate_IR | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-54143@lists.php.net to get a copy of this message | ||
Jesús Espino (http://pear.php.net/user/jespino) has voted +1 on the proposal for
Validate::Validate_IR.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=652
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=652&handle=jespino
This vote is conditional. The condition is:
You haven't fixed the problems that Daniel O'Connor has notified, fix thats problems and
you get my +1 vote. You can fix that in your tar.gz file published in the proposal url (the link is
not correct, because you link .tgz and the file is .tar.gz), o you can fix this in the github
repository, but fix the problems anywhere.
Problems:
* Mix of whitespaces and tab characters in the indentation. (Review the code with PHP_CodeSniffer,
or fix the problems with whitespaces manually) Thats not critical, but is a good practice.
* package.xml not exists.