[PEPr] +1 for Validate::Validate_IR

From: Date: Fri, 18 Mar 2011 01:40:42 +0000
Subject: [PEPr] +1 for Validate::Validate_IR
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-54161@lists.php.net to get a copy of this message
Damien Bezborodov (http://pear.php.net/user/dbezborodov) has voted +1 on the proposal for Validate::Validate_IR. Proposal information: http://pear.php.net/pepr/pepr-proposal-show.php?id=652 Vote information: http://pear.php.net/pepr/pepr-vote-show.php?id=652&handle=dbezborodov This vote is conditional. The condition is: Looks alright to me. Not sure why it doesn't extend a Validate_Interface or something, but that is out of scope for this review. I noticed one tiny bug: '/[0-9]{4}-?[0-9]{4}-?[0-9]{4}-?[0-9]{4}$/' is missing the start ^ should be: '/^[0-9]{4}-?[0-9]{4}-?[0-9]{4}-?[0-9]{4}$/' test to prove that is broken would be nice before you fix it. Also, the ssn could do with some comments explaining what's going on there. Looks complicated. :) Good work, squire.

« previous php.pear.dev (#54161) next »