[PEPr] Comment on HTML::HTML_QuickForm2_Renderer_Smarty
| From: | Daniel O'Connor | Date: | Sat, 09 Jul 2011 14:29:52 +0000 |
| Subject: | [PEPr] Comment on HTML::HTML_QuickForm2_Renderer_Smarty | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-54367@lists.php.net to get a copy of this message | ||
Are you still working on this proposal? If so; you might want to run
PHP_CodeSniffer over your code - there's a few things in there which need
looking at.
IE
if( ! isset($top[$top_key]))
$top[$top_key] = &$elem; // Link into the level
above
or comparisons like
$top_key != ''
instead of !empty.
--
http://pear.php.net/pepr/pepr-proposal-show.php?id=653