Re: [PEPr] +1 for HTML::HTML_QuickForm2_Renderer_Smarty

On Thu, Nov 10, 2011 at 03:17:46AM +0000, Daniel O'Connor wrote: > Daniel O'Connor (http://pear.php.net/user/doconnor) has voted +1 on the proposal for > HTML::HTML_QuickForm2_Renderer_Smarty. > > Proposal information: > http://pear.php.net/pepr/pepr-proposal-show.php?id=653 > Vote information: > > http://pear.php.net/pepr/pepr-vote-show.php?id=653&handle=doconnor > > This vote is conditional. The condition is: > > As per PHP_CodeSniffer comments I have run that on my code (line numbers have changed from what you can see): Some of it is plain wrong, some of it plain stupid. Eg on the line below: * @category HTML it says: 39 | ERROR | @category tag comment indented incorrectly; expected 1 spaces | | but found 3 I have had a look at other pear modules ... they seem to do the same thing ... as I would expect since I just copied it from one. Other lines: 164 | ERROR | Line indented incorrectly; expected at least 4 spaces, found 3 This is as it was in the module that I modified. 180 | ERROR | Expected 1 space before variable type 180 | ERROR | Doc comment for var Element does not match actual variable | | name $element at position 1 It is wrong --- the type is correct. 202 | ERROR | Expected "if (...) {\n"; found "if(...) {\n" What a damn stupid error! 280 | ERROR | Multi-line function call not indented correctly; expected 16 | | spaces but found 20 If I were to do that then the continuation line would have the same indent at the first line, that is plainly wrong. 284 | ERROR | Opening parenthesis of a multi-line function call must be the | | last content on the line 280 | ERROR | Closing parenthesis of a multi-line function call must be on a | | line by itself WTF ? 313 | ERROR | Missing comment for param "$inGroup" at position 3 That is a lie. 355 | ERROR | Closing parenthesis of a multi-line IF statement must be on a | | new line -- Alain Williams Linux/GNU Consultant - Mail systems, Web sites, Networking, Programmer, IT Lecturer. +44 (0) 787 668 0256 http://www.phcomp.co.uk/ Parliament Hill Computers Ltd. Registration Information: http://www.phcomp.co.uk/contact.php #include <std_disclaimer.h>