Re: Re: [pear/Net_Sieve] 8f7d9b: Replaced PEAR::isError() by is_a(..., "PEAR_Error"...
| From: | Jan Schneider | Date: | Thu, 01 Sep 2011 08:56:06 +0000 |
| Subject: | Re: Re: [pear/Net_Sieve] 8f7d9b: Replaced PEAR::isError() by is_a(..., "PEAR_Error"... | ||
| References: | 1 2 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-54473@lists.php.net to get a copy of this message | ||
Zitat von Alan Knowles <alan@akbkhome.com>:
You might want to add some is_object() checks around those.Why? The only issue with recent PHP changes is that it triggers autoloading if not passing an object right? That isn't anything I really care about at this point.
On Wednesday, August 31, 2011 04:47 PM, noreply@github.com wrote:Jan. -- Do you need professional PHP or Horde consulting? http://horde.org/consulting/Branch: refs/heads/master Home: https://github.com/pear/Net_Sieve Commit: 8f7d9bc27eb192eb9ddf76194e158f895e61bf31--PEAR Development Mailing List (http://pear.php.net/) To unsubscribe, visit: http://www.php.net/unsub.phphttps://github.com/pear/Net_Sieve/commit/8f7d9bc27eb192eb9ddf76194e158f895e61bf31Author: Christian Hammers<ch@lathspell.de> Date: 2011-08-30 (Tue, 30 Aug 2011) Changed paths:M Sieve.phpLog Message: ----------- Replaced PEAR::isError() by is_a(..., "PEAR_Error") as the former was not PHP E_STRICT compliant. Commit: 90393c48d03d173774e4a1375b174eb501096211https://github.com/pear/Net_Sieve/commit/90393c48d03d173774e4a1375b174eb501096211Author: Jan Schneider<jan@horde.org> Date: 2011-08-31 (Wed, 31 Aug 2011) Changed paths:M Sieve.phpLog Message: ----------- Merge pull request #1 from lathspell/master https://pear.php.net/bugs/bug.php?id=18663 Compare: https://github.com/pear/Net_Sieve/compare/9075385...90393c4