Re: Re: [pear/Net_Sieve] 8f7d9b: Replaced PEAR::isError() by is_a(..., "PEAR_Error"...

I'd rather spend the time on porting Net_Sieve to PHP 5/PEAR2 though and get rid of PEAR_Error and is_a() altogether. Zitat von Phone <mailinglist@akbkhome.com>:

I did eyeball the code, i think one of the methods returns mixed string|pear_error. The reports i got was that a few people where throwing exceptions in the autoloader if class was not found. (Not an unreasonable behaviour). Hence pear code was crashing their applications. Regards Alan -- Sent from my Android phone with K-9 Mail. Please excuse my brevity.

    
Jan Schneider <jan@horde.org> wrote:   > Zitat von Alan Knowles <alan@akbkhome.com>:  > You might want to add some is_object() checks around those.  Why? The only issue with recent PHP changes is that it triggers   autoloading if not passing an object right? That isn't anything I   really care about at this point.  > On Wednesday, August 31, 2011 04:47 PM, noreply@github.com wrote: >>   Branch: refs/heads/master >>   Home:   https://github.com/pear/Net_Sieve >> 
  Commit: 8f7d9bc27eb192eb9ddf76194e158f895e61bf31 >>         >> 
https://github.com/pear/Net_Sieve/commit/8f7d9bc27eb192eb9ddf76194e158f895e61bf31 >>   Author: Christian Hammers<ch@lathspell.de> >>   Date:   2011-08-30 (Tue, 30 Aug 2011) >> >>   Changed paths: >>     M Sieve.php >> >>   Log Message: >>   ----------- >>   Replaced PEAR::isError() by is_a(..., "PEAR_Error") as the former   >> was not PHP E_STRICT compliant. >> >> >>   Commit: 90393c48d03d173774e4a1375b174eb501096211 >>         >> https://github.com/pear/Net_Sieve/commit/90393c48d03d173774e4a1375b174eb501096211 >>   Author: Jan Schneider<jan@horde.org> >>   Date:   2011-08-31 (Wed, 31 Aug 2011) >> >>   Changed paths: >>     M Sieve.php >> >>   Log Message: >>   ----------- >>   Merge pull request #1 from lathspell/master >> >> https://pear.php.net/bugs/bug.php?id=18663 >> >> >> Compare: https://github.com/pear/Net_Sieve/compare/9075385...90393c4 >> > > > --  > PEAR Development Mailing List (http://pear.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php   Jan.  --  Do you need professional PHP or Horde consulting? http://horde.org/consulting/   --  PEAR Development Mailing List (http://pear.php.net/) To unsubscribe, visit: http://www.php.net/unsub.php

Jan. -- Do you need professional PHP or Horde consulting? http://horde.org/consulting/