[PEPr] +1 for PHP::Mailman
| From: | Ken Guest | Date: | Thu, 15 Sep 2011 23:33:03 +0000 |
| Subject: | [PEPr] +1 for PHP::Mailman | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-54509@lists.php.net to get a copy of this message | ||
Ken Guest (http://pear.php.net/user/kguest) has voted +1 on the proposal for PHP::Mailman.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=665
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=665&handle=kguest
This vote is conditional. The condition is:
Adherence to PEAR CS is good, and overall I like what you've done; but there are a few things
you need to do before you entirely get my vote.
* Docblocks need to be updated - the constructor's "@return" should be "@return
PHP_Mailman", for example.
* This package doesn't fit into the PHP category - this is a Service package that integrates
with Mailman, not one that does PHP specific 'work'.
* Use http_build_query rather than hardcoding query strings.
* Don't parse HTML using regular expressions - this is a very brittle approach