[PEPr] +1 for PHP::Mailman
| From: | Christian Weiske | Date: | Thu, 15 Sep 2011 23:41:43 +0000 |
| Subject: | [PEPr] +1 for PHP::Mailman | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-54510@lists.php.net to get a copy of this message | ||
Christian Weiske (http://pear.php.net/user/cweiske) has voted +1 on the proposal for PHP::Mailman.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=665
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=665&handle=cweiske
This vote is conditional. The condition is:
- No unittests - this is the biggest problem. since you're already using http_request2, you can
mock the mail admin away easily.
- Docblock problems like "@return unknown Return description"
- "setdigest" needs to be setDigest
- Code that may have unexpected results:
if ($object instanceof HTTP_Request2) {
$this->req = $object;
} else {
$this->req = new HTTP_Request2();
}
-> here you just ignore what the user put in since you don't specify the object type in
the signature.
- setAdminURL: return; although you write @return boolean
- you should use exceptions instead of setError.
This vote is very conditional.