Re: [PEPr] Proposal for Date and Time::Date_HumanDiff
| From: | Markus Tacker | Date: | Tue, 17 Apr 2012 11:58:46 +0000 |
| Subject: | Re: [PEPr] Proposal for Date and Time::Date_HumanDiff | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-54916@lists.php.net to get a copy of this message | ||
Hoi Christian,
On Tue, Apr 17, 2012 at 14:45, Christian Weiske <cweiske@php.net> wrote:
> Christian Weiske (http://pear.php.net/user/cweiske) proposes Date and Time::Date_HumanDiff.
Good idea to bake this into a pear package!
- There should be an addFormat($fmt) method.
- make sure that formats is sorted by the threshold
- formats should be an entity
- get() should accept DateTime objects
- Put the english localisation in a subclass HumanDiff_EN
- Missing PHP docs in the tests file
- remove the ?> at EOF
Just my 2cents™.
--
mit freundlichen Grüßen
Markus Tacker ~ http://tckr.cc/