Re: [PEPr] Comment on Date and Time::Date_HumanDiff

Hello Markus and Till, > - There should be an addFormat($fmt) method. Done. > - make sure that formats is sorted by the threshold Done. > - formats should be an entity No, I keep them as an array - don't want to add unneeded complexity for now. > - get() should accept DateTime objects Done. > - Put the english localisation in a subclass HumanDiff_EN No, but I've added support for translations and added a German one. The english one is the reference "translation" provided by the formats. > - Missing PHP docs in the tests file I never added docblocks in test files; there is not really a point in my eyes. > - remove the ?> at EOF Why? I like them; they keep the world balanced. > it would be nice if other variants like date('r') (RFC date) > are supported You can use all strtotime()-compatible strings now. http://pear.php.net/pepr/pepr-proposal-show.php?id=678 -- Regards/Mit freundlichen Grüßen Christian Weiske -=≡ Geeking around in the name of science since 1982 ≡=-

Attachment: [application/pgp-signature] signature.asc