[PEPr] Comment on Caching::phpfastcache

From: Date: Mon, 13 May 2013 21:06:50 +0000
Subject: [PEPr] Comment on Caching::phpfastcache
References: 1  Groups: php.pear.dev 
Request: Send a blank email to pear-dev+get-55224@lists.php.net to get a copy of this message
After looking at the code, I agree with Bertand. This class is doing too much. For example, emailing error messages does not belong in a cache library. There is definitely room in PEAR for a cache library, but the code needs to be split into multiple reusable classes rather than one monolithic static class. Serializing cache data is potentially a security issue as a vulnerability in any backend now has the potential to execute code on the server. -- http://pear.php.net/pepr/pepr-proposal-show.php?id=692

« previous php.pear.dev (#55224) next »