[PEPr] -1 for Caching::phpfastcache
| From: | Stelian Mocanita | Date: | Tue, 06 Aug 2013 00:11:20 +0000 |
| Subject: | [PEPr] -1 for Caching::phpfastcache | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-55255@lists.php.net to get a copy of this message | ||
Stelian Mocanita (http://pear.php.net/user/stelianm) has voted -1 on the proposal for
Caching::phpfastcache.
Proposal information:
http://pear.php.net/pepr/pepr-proposal-show.php?id=692
Vote information:
http://pear.php.net/pepr/pepr-vote-show.php?id=692&handle=stelianm
Comment:
Along with the issues/recommendations Bertrand exposed in his vote, I would
also like to add:
- getOS is defined twice
- a lot of file operations without any error handling (fopen, opendir,
etc)
- not entirely sure why you need to call an external api call in this
particular case, but since you have it there, file_get_contents is #1
blocking and #2 it emits and E_WARNING.
As a side note, when you link to github, redirect me there and do not ask
for my e-mail.