Re: Whitespace and snow blindness
| From: | Rasmus Lerdorf | Date: | Thu, 16 May 2002 15:15:02 +0000 |
| Subject: | Re: Whitespace and snow blindness | ||
| References: | 1 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-6150@lists.php.net to get a copy of this message | ||
Just for the record, I much prefer the more concise style Kristian used.
Sometimes you also have to keep context in mind. Splitting an
insignificant debug line up over 18 lines makes very little sense.
-Rasmus
On Thu, 16 May 2002, Sebastian Bergmann wrote:
> Kristian Koehntopp wrote:
> > Sebastian, will you please visit less Java lectures and university?
>
> Sure, if you give me my Diploma and save me the hassle.
>
> > My single line of code:
> > - $r = sprintf("Stackdump (level: %s) follows:\n", $this->_level);
> >
> > Your reformatting, covering half the gobi desert:
> > + $r = sprintf(
> > + "Stackdump (level: %s) follows:\n",
> > + $this->_level
> > + );
>
> I see your point, but it is only valid for lines shorter than 70+
> characters. I think you'll agree that overlong lines are bad.
>
> Why do I apply the same style used to shorten those long lines to
> not so long lines? Consistency.
>
> > Now please open that 80x25 konsole, black background, green text
> > and try to read and understand the above code. And then reverse
> > these patches.
>
> The code looks okay to me and I will nothing do the like, sorry.
>
> --
> Sebastian Bergmann
> http://sebastian-bergmann.de/
> http://phpOpenTracker.de/
>
> Did I help you? Consider a gift:
> http://wishlist.sebastian-bergmann.de/
>
> --
> PEAR Development Mailing List (http://pear.php.net/)
> To unsubscribe, visit: http://www.php.net/unsub.php
>