Re: Whitespace and snow blindness

On Thu, 16 May 2002 16:34:05 +0200, Sebastian Bergmann wrote: >Kristian Koehntopp wrote: >> Sebastian, will you please visit less Java lectures and university? > > Sure, if you give me my Diploma and save me the hassle. > >> My single line of code: >> - $r = sprintf("Stackdump (level: %s) follows:\n", $this->_level); >> >> Your reformatting, covering half the gobi desert: >> + $r = sprintf( >> + "Stackdump (level: %s) follows:\n", >> + $this->_level >> + ); > > I see your point, but it is only valid for lines shorter than 70+ > characters. I think you'll agree that overlong lines are bad. > > Why do I apply the same style used to shorten those long lines to > not so long lines? Consistency. When it comes to the comparison of consistency and readability, I pretty much prefer the second one in most cases. >> Now please open that 80x25 konsole, black background, green text >> and try to read and understand the above code. And then reverse >> these patches. > > The code looks okay to me and I will nothing do the like, sorry. I agree with Kristian that the changes don't support easy code reading. +1 for reverting the patch. - Martin -- Martin Jansen, <mail@martin-jansen.de> http://www.martin-jansen.de/