Re: RE: [PEAR-CVS] cvs: pearweb /public_html package-search.php /public_html/gifs calendar.gif tri-back.gif tri.gif /public_html/javascript/calendar
calendar.css calendar.js /public_html/javascript/xbApi xbApi.common.js xbApi.dom.js xbApi.ie.js xbApi.loade
| From: | Martin Jansen | Date: | Mon, 27 May 2002 10:17:40 +0000 |
| Subject: | Re: RE: [PEAR-CVS] cvs: pearweb /public_html package-search.php /public_html/gifs calendar.gif tri-back.gif tri.gif /public_html/javascript/calendar calendar.css calendar.js /public_html/javascript/xbApi xbApi.common.js xbApi.dom.js xbApi.ie.js xbApi.loade |
||
| Groups: | php.pear.dev | ||
| Request: | Send a blank email to pear-dev+get-6464@lists.php.net to get a copy of this message | ||
On Mon, 27 May 2002 10:22:50 +0100, Richard Heyes wrote:
>> Wouldn't it be better to move package-search.html back into
>> package-search.php? From my point of view it doesn't make much sense
>> to split this up.
>
>Templates are the way to go imho. It certainly makes the code easier to
>read and maintain.
Yeah, but we didn't implement a stable template system yet. And
simply using include("template.html") isn't a real template engine
btw, even if it's the fastest one :).
>> Apart from that we should really consider to not use <?foreach($foo as
>> $bar):?>
>> and friends, since pear.php.net is our showcase and it should show
>> people how to write clean code.
>
>Pearweb is far from showcase code,
Then let's try to bring it to a point where it actually is showcase code.
>and to be honest I think the use of templates
>is a step towards this. I don't think there's anything wrong with short
>tags and alternative syntax, as it makes the "template" much easier to
>read.
Until now it has been a convention on pear.php.net to not use short
tags and consistency is a Good Thing [tm] ;-). Anyways, before I
start yet another useless discussion, I stop here and let the
decision open to you, if you are gonna change it or not.
- Martin
--
Martin Jansen, <mail@martin-jansen.de>
http://www.martin-jansen.de/