Bug #17585: net/SMTP.php fails with dashes

From: juegajedrez@hotmail.com Operating system: Windows 2000 PHP version: 4.2.1 PHP Bug Type: PEAR related Bug description: net/SMTP.php fails with dashes When connecting to a Microsoft Exchange Server (acad.ursinus.edu:25), pear/net/SMTP.php fails to correctly parse the server response in the ValidateAndParseResponse() function. the code segment: 1} else { 2 $reply_code = strtok($this->lastline, '-'); 3 if (strcmp($code, $reply_code)) { 4 $this->code = $reply_code; 5 return true; 6 } 7} is incorrect on line 3. We want this to return true (as it does above the code shown) when "if(!(strcmp($code, $reply_code)))" returns true. Without this change, The code will not parse valid responses from the server if they are followed with a dash. I downloaded the most recent version of php just a few days ago, and it contains this error. I tried to verify that this error still exists by using the CVS, but I could not find the net/SMTP.php file there. If it has been fixed, I apologize for the repitition. peace Bill Mill -- Edit bug report at http://bugs.php.net/?id=17585&edit=1 -- Fixed in CVS: http://bugs.php.net/fix.php?id=17585&r=fixedcvs Fixed in release: http://bugs.php.net/fix.php?id=17585&r=alreadyfixed Need backtrace: http://bugs.php.net/fix.php?id=17585&r=needtrace Try newer version: http://bugs.php.net/fix.php?id=17585&r=oldversion Not developer issue: http://bugs.php.net/fix.php?id=17585&r=support Expected behavior: http://bugs.php.net/fix.php?id=17585&r=notwrong Not enough info: http://bugs.php.net/fix.php?id=17585&r=notenoughinfo Submitted twice: http://bugs.php.net/fix.php?id=17585&r=submittedtwice register_globals: http://bugs.php.net/fix.php?id=17585&r=globals