Bug #17585 Updated: net/SMTP.php fails with dashes

ID: 17585 Updated by: tal@php.net Reported By: juegajedrez@hotmail.com -Status: Closed +Status: Bogus Bug Type: PEAR related Operating System: Windows 2000 PHP Version: 4.2.1 New Comment: Not a bug -- Marking as Bogus. -Tal Previous Comments: ------------------------------------------------------------------------ [2002-06-03 21:49:10] juegajedrez@hotmail.com My fault. Misunderstood the algorithm. more patience before a post next time :( ------------------------------------------------------------------------ [2002-06-03 21:04:02] juegajedrez@hotmail.com Sorry about that not found on the CVS thing, I'm a moron. The file on the CVS still contains this error - Bill ------------------------------------------------------------------------ [2002-06-03 20:55:21] juegajedrez@hotmail.com When connecting to a Microsoft Exchange Server (acad.ursinus.edu:25), pear/net/SMTP.php fails to correctly parse the server response in the ValidateAndParseResponse() function. the code segment: 1} else { 2 $reply_code = strtok($this->lastline, '-'); 3 if (strcmp($code, $reply_code)) { 4 $this->code = $reply_code; 5 return true; 6 } 7} is incorrect on line 3. We want this to return true (as it does above the code shown) when "if(!(strcmp($code, $reply_code)))" returns true. Without this change, The code will not parse valid responses from the server if they are followed with a dash. I downloaded the most recent version of php just a few days ago, and it contains this error. I tried to verify that this error still exists by using the CVS, but I could not find the net/SMTP.php file there. If it has been fixed, I apologize for the repitition. peace Bill Mill ------------------------------------------------------------------------ -- Edit this bug report at http://bugs.php.net/?id=17585&edit=1