MDB patches
| From: | Paul Cooper | Date: | Mon, 15 Jul 2002 10:56:09 +0000 |
| Subject: | MDB patches | ||
| Groups: | php.pear.dev | ||
| Request: | Send a blank email to pear-dev+get-7720@lists.php.net to get a copy of this message | ||
Here are two patches, one for pgsql.php and the other for
manager_pgsql.php
The manager patch is just PHPDoc stuff and CS cleanup.
The pgsql driver patch fixes a nasty infinite loop between the connect
and query methods. Before executing a query, the query method calls the
connect method, which, after connecting, tries to wrap the session in a
transaction (if auto_commit is off) and so calls query("BEGIN"), and so
the loop begins (!). Such transactional calls should be using the
private method _doQuery (like in the original metabase driver) so I went
through the driver and changed all such from query to _doQuery. There
are also other misc CS cleanups in the patch.
I can now run MDB_test perfectly and driver test with some errors (which
I'm working on now).
HTH,
Paul
--
-----------------------------------------------------------------
Paul Cooper | Tel: 0121 331 7858
Senior Programmer and Database Engineer | Fax: 0121 331 7859
UCEcom | mailto:pgc@ucecom.com
University of Central England | http://www.ucecom.com
Birmingham, B4 7DX |
-----------------------------------------------------------------
Attachment: [text/x-patch] pgsql.diff
Attachment: [text/x-patch] manager_pgsql.diff
Attachment: [text/x-patch] pgsql.diff
Attachment: [text/x-patch] manager_pgsql.diff