Re: Log Diffs
| From: | Tomas V.V.Cox | Date: | Mon, 15 Jul 2002 10:57:38 +0000 |
| Subject: | Re: Log Diffs | ||
| References: | 1 2 3 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-7721@lists.php.net to get a copy of this message | ||
Jon Parise wrote:
>
> On Wed, Jul 10, 2002 at 08:09:03PM +0200, Tomas V.V.Cox wrote:
>
> > Why not just integrate pearToSys() in priorityToString()?
>
> Agreed. That would be clearer and cleaner.
>
> I'm also note sure I like the way that the PEAR_LOG_* constants are
> defined in the Log constructor. It would be nicer to define them
> globally so that those values could be used before the Log object has
> been created (e.g. in configuration files).
>
> I'd like to see the above issues addressed before a commit is made.
What about the attached patch. This should allow people use indistictly
LOG_* or PEAR_LOG_*. As only the syslog "container" is affected by the
change (as far as I see) I've moved pearToSys() there as a private func.
Tomas V.V.Cox
PS.- I've commited btw the patch for
http://bugs.php.net/bug.php?id=18311