Re: Log Diffs

--- Jon Parise <jon@php.net> wrote: > On Wed, Jul 10, 2002 at 08:09:03PM +0200, Tomas V.V.Cox wrote: > > > Why not just integrate pearToSys() in priorityToString()? > > Agreed. That would be clearer and cleaner. How would this be possible?? one function is designed to return a string and the other is designed to return an integer. The only way I could see to do this would be to add an extra parameter to the priorityToString function which would return a LOG_* integer if set. Since the LOG_* integer is only needed for syslog, I thought it would be easier to keep them seperate. Please enlighten me if there is an easier way. > > I'm also note sure I like the way that the PEAR_LOG_* constants are > defined in the Log constructor. It would be nicer to define them > globally so that those values could be used before the Log object has > been created (e.g. in configuration files). fair enough > > I'd like to see the above issues addressed before a commit is made. > > -- > Jon Parise (jon@csh.rit.edu) . Information Technology (2001) > http://www.csh.rit.edu/~jon/ : Computer Science House Member > > -- > PEAR Development Mailing List (http://pear.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > __________________________________________________ Do You Yahoo!? Yahoo! Autos - Get free new car price quotes http://autos.yahoo.com