Re: Log Diffs
| From: | Jon Parise | Date: | Sun, 14 Jul 2002 01:52:59 +0000 |
| Subject: | Re: Log Diffs | ||
| References: | 1 2 | Groups: | php.pear.dev |
| Request: | Send a blank email to pear-dev+get-7711@lists.php.net to get a copy of this message | ||
On Wed, Jul 10, 2002 at 08:09:03PM +0200, Tomas V.V.Cox wrote:
> Why not just integrate pearToSys() in priorityToString()?
Agreed. That would be clearer and cleaner.
I'm also note sure I like the way that the PEAR_LOG_* constants are
defined in the Log constructor. It would be nicer to define them
globally so that those values could be used before the Log object has
been created (e.g. in configuration files).
I'd like to see the above issues addressed before a commit is made.
--
Jon Parise (jon@csh.rit.edu) . Information Technology (2001)
http://www.csh.rit.edu/~jon/ : Computer Science House
Member