a couple observations on the Mail_Mime package
| From: | Robert P. J. Day | Date: | Thu, 25 Feb 2010 11:02:33 +0000 |
| Subject: | a couple observations on the Mail_Mime package | ||
| Groups: | php.pear.general | ||
| Request: | Send a blank email to pear-general+get-30312@lists.php.net to get a copy of this message | ||
(fairly new to PHP and PEAR so be gentle ...)
first, a minor syntactical mismatch -- the file mime.php refers to
the method "addSubpart", while that method is defined in mimePart.php
as "addSubPart". obviously not an error but it took me a couple
minutes to notice that as i was grepping for where that method was
defined.
next, in the constructor for Mail_mimePart, there is a reference to
the "description" field, which is (as i understand it) where the
comment field for an attachment would be placed. but if you go back
to mime.php, there is absolutely no reference to that field. it would
seem to be convenient to add that field to each attachment, but it's
not well-documented in mime.php as to how you'd do that. perhaps that
should be made clearer?
finally, at the top of mime.php, there is a declaration for the
class variable "$_mime", but it's not clear to me where that's being
used anywhere. am i just missing it? thanks.
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Linux Consulting, Training and Kernel Pedantry.
Web page: http://crashcourse.ca
Twitter: http://twitter.com/rpjday
========================================================================