Re: a couple observations on the Mail_Mime package

Robert P. J. Day wrote:

first, a minor syntactical mismatch -- the file mime.php refers to the method "addSubpart", while that method is defined in mimePart.php as "addSubPart". obviously not an error but it took me a couple minutes to notice that as i was grepping for where that method was defined.

fixed in svn

next, in the constructor for Mail_mimePart, there is a reference to the "description" field, which is (as i understand it) where the comment field for an attachment would be placed. but if you go back to mime.php, there is absolutely no reference to that field. it would seem to be convenient to add that field to each attachment, but it's not well-documented in mime.php as to how you'd do that. perhaps that should be made clearer?

It's not possible to set Content-Description via mime.php. Create a request in bugtrucker, please.

finally, at the top of mime.php, there is a declaration for the class variable "$_mime", but it's not clear to me where that's being used anywhere. am i just missing it? thanks.

fixed in svn -- Aleksander 'A.L.E.C' Machniak http://alec.pl gg:2275252 LAN Management System Developer http://lms.org.pl Roundcube Webmail Developer http://roundcube.net