RE: [PEAR] [Patch]LiveUser

Hi! I checked out the changes Jean-Marc proposed. The idea of the readConfigArray() method sounds good to me. It seems to be a smarter way to change standard values than the one I'm using in the examples. I just want to add one line: <snip> if (is_array($configArray)) { foreach ($configArray as $key => $value) { + if (isset($this->$key)) { $this->$key = $value; + } } return true; } </snip> The change in _readConfigFilePHP() is definitely wrong here. Think about the situation you already imported the file for some reasons: You won't be able to access the config var in the method. All other modifications seems to be ok. Regards Bjoern > -----Original Message----- > From: pear-general-return-4747-bjoernkraus=web.de@lists.php.net > [mailto:pear-general-return-4747-bjoernkraus=web.de@lists.php.net]On > Behalf Of Jean-Marc Fontaine > Sent: Wednesday, April 09, 2003 9:37 PM > To: pear-general@lists.php.net > Subject: [PEAR] [Patch]LiveUser > > > Hello, > > as a contribution to help LiveUser development, I am posting a patch > proposal. > > This fixes a little bug in the LoginManager::_readConfigFilePHP() method > when the config file was already included by replacing "include" by > "include_once" > > I also added a readConfigArray() in order to avoid using a configuration > file. I added this beacuse I think it may be convenient in many > cases, or at > least in my case ;-) > > Let me know what you think of this. > > Regards > > Jean-Marc > > >