RE: [PEAR] [Patch]LiveUser

That's a question to our lead developer ;) IMHO it's not a good idea to increase the package dependencies. Regards Bjoern > -----Original Message----- > From: bmansion@mamasam.com [mailto:bmansion@mamasam.com] > Sent: Monday, April 14, 2003 12:00 AM > To: Bjoern Kraus; pear-general@lists.php.net; LiverUser-List > Subject: Re: [PEAR] [Patch]LiveUser > > > <bjoernkraus@web.de> wrote : > > > Hi! > > > > I checked out the changes Jean-Marc proposed. > > The idea of the readConfigArray() method sounds good to me. It > seems to be a > > smarter way to change standard values than the one I'm using in the > > examples. I just want to add one line: > > > > <snip> > > if (is_array($configArray)) { > > foreach ($configArray as $key => $value) { > > + if (isset($this->$key)) { > > $this->$key = $value; > > + } > > } > > return true; > > } > > </snip> > > > > The change in _readConfigFilePHP() is definitely wrong here. > Think about the > > situation you already imported the file for some reasons: You > won't be able > > to access the config var in the method. > > > > All other modifications seems to be ok. > > Hi Bjoern, > > I have written and released the Config package. I would suggest > you use the > same format as the one that is output by Config when you parse the XML > liveuser config and output it as a php array. The main difference > is that it > adds # for values and @ for attributes when these are set in the XML. > > If you want to test it, there are some examples in the docs/ directory of > the package. > > Why use this format instead of the older one ? > > Because when you will want to write a front-end for liveUser, it will be > made easier if you use this class. It will also be easier for users to > manipulate their liveuser config files. > > Please let me know what you think of this idea. > > Bertrand Mansion > Mamasam > > > -- > PEAR General Mailing List (http://pear.php.net/) > To unsubscribe, visit: http://www.php.net/unsub.php > >