ramificatiopns of change to Auth/Auth.php
| From: | jsWalter | Date: | Sun, 31 Aug 2003 05:28:08 +0000 |
| Subject: | ramificatiopns of change to Auth/Auth.php | ||
| Groups: | php.pear.general | ||
| Request: | Send a blank email to pear-general+get-7506@lists.php.net to get a copy of this message | ||
I'm playing with Auth (for now) and I made a small change to an internal
method...
function _factory($driver = 'DB', $options = "")
This sets the default "driver'" type to DB.
Does anyone know the ramifications of this?
Will this come bit me in the butt later?
I did this so I could do this...
$a = new Auth();
so I can do validation of session without having to define DRIVER type.
I figured, since driver type parameters are optional why not driver type
itself. Looking deeper into the methods, I saw that loads storage classes
based upon this definition. My first thought was to have the '_factory'
method just bale out if no type is defined, but It thought that might break
something I'm not seeing, so, I figured just default to 'DB'. But then I had
second thoughts on that and now I'm asking those wiser than I.
I really feel that all parameters to auth() should be optional, since AFAIK
(or can see) they are not used beyond the initial authorization or new user
DB (or whatever driver type) access.
Please enlighten me. I'm asking now before I screw myself into a hole
(again) and can't get out.
Thanks
Walter