Re: HTTP_Upload patches

On 29 May 2004 at 2:42, Christian Wenz wrote: > to my great surprise fellow PEAR user Antonio committed several patches > to HTTP_Upload today. I certainly appreciate all help on this (or any > other) package, however I was rather surprised because he is not listed > on the package's website but obviously has write access to the CVS > directory (which I don't, but that's another story :) ). > As I wrote a couple of days ago, I have prepared a "monster patch" that > includes some of the fixes Antonio has committed, however it also > contains additonal patches. > My question is what the general recommendation in this case is: shall I > try to apply my patches to the current version in CVS (as soon as I have > write access; would mean doing the same kind of work again, but is > probably the preferable solution), or should I just commit "my version" > of the package (which would mean overwriting Antonio's efforts)? I > appreciate your opinions on that. How large are those changes that Antonio did? If those were just a few lines that you are sure you have done as good as him, then I don't see a problem why you couldn't simply commit your patch. Otherwise maybe doing a local cvs merge and trying it out might also be a good solution. Just make sure you don't exchange good (and maybe quite large and maybe extensively tested) patches of Antonio with quickfixes of yours or something like that. Everything else is fine imho. Stefan