Re: Re: CRLF -> LF

From: Date: Sat, 12 Jun 2004 15:17:36 +0000
Subject: Re: Re: CRLF -> LF
References: 1 2  Groups: php.pear.qa 
Request: Send a blank email to pear-qa+get-1446@lists.php.net to get a copy of this message
Stefan Neufeind wrote:
On 12 Jun 2004 at 14:26, PHP wrote:
Might be doable for files with types like php or text etc. Maybe someone with more packager-knowledge might propose a solution?
Of course it's possible, but will we also begin to fix other CS violations in files? Also, in doing this, we'll /still/ keep a messy CVS with CR, CRLF, LF, and files with multiple of those. Also, forcing devs to fix these lineendings will fuck with CVS. It'll assume all the lines have changed, which makes diff's horrible to read. Consider comparing your current/local version, to a version that's been fixed for line-endings. By default, it'd mark all lines as changed, eventhough few may be really changed. Dev-education would be the best way to go here, not forcing them upon the files at some point.
Maybe auto-correcting the files on the cvs-server when commiting :-)) But honestly: Yeah, see the problem.
Autocorrecting things is a dangerous thing imho. Its likely to do more harm as good. Warnings is more approriate if all (similar to the API prefix check that was implemented into pear package). regards, Lukas Smith smith@backendmedia.com _______________________________ BackendMedia www.backendmedia.com berlin@backendmedia.com Linn Zwoch Smith GbR Pariser Str. 44 D-10707 Berlin Tel +49 30 83 22 50 00 Fax +49 30 83 22 50 07

« previous php.pear.qa (#1446) next »