Re: Re: CRLF -> LF
| From: | Andrey Demenev | Date: | Sun, 13 Jun 2004 12:56:05 +0000 |
| Subject: | Re: Re: CRLF -> LF | ||
| References: | 1 2 | Groups: | php.pear.qa |
| Request: | Send a blank email to pear-qa+get-1463@lists.php.net to get a copy of this message | ||
Stefan Neufeind wrote:
Yes, it can be done there. BTW, after looking closer to source of PEAR_Packager, I see there is a typo that prevents writing of md5 checksums into package.xml [1]. Also, if original package.xml was produced with md5 checksums, checksums don't get updated in package.xml included into the tarball. [1] http://pear.php.net/bugs/bug.php?id=1627 -- Andrey Demenev aka Blindman demenev@on-line.jar.ruForcing people to use correct line-endings does not solve the problem. After CVS checkout on Windows, line-endings will be converted to CRLF, even if checked in files used CR. After issueing pear package, the tarball will contain files with "wrong" line-endings. I do think we need auto-conversion (either in packager or in installer), if we care about line-endings. Doing it in installer seems more reasonable, 'cos otherwise problems with md5 checksums would come up.Couldn't this be done prior to checksum-calculation in the "pear package"-step? Stefan