Re: Re: cvs: pear /Mail_Mime mime.php

On Thu, 16 Dec 2004 10:31:01 -0500, Sean Coates <sean@caedmon.net> wrote: > Hello, QA. > > I made a large CS commit yesterday, and received a few comments that > seem like opinions, and I don't see in the CS part of the manual, so I > thought it best to run them by you. > > First was: > > true and false should be lowercase, not uppercase. > My reply was: > -CUT- > I don't want to overstep my bounds, here, so please take this as a > simple question: > > Where is this indicated in the Coding Standards? > The only possible refererence I can find to true being lowercase is in > the Sample file, which, according to the Naming Conventions page is in > error. > > "Constants should always be all-uppercase, with underscores to separate > words." > > Unless, for some reason, PEAR-folk don't consider TRUE and FALSE (er.. > true and false) to be constants.. ? true, false, and null are language constructs, not constants. This isn't currently in the CS on the website, but it is generally accepted as CS and always mentioned in proposal comments. > -CUT- > > But I didn't CC it here. So... ? > > Second: > > * Ditch the parentheses around the requires. > The manual is also unclear on this. Is this necessary? What is "proper"? eh...this is still IMHO personal preference. AFAIK, you *may* do it either way but you're encouraged to not have parenthesis. *I* still usually use parenthesis myself. > > I'll send a patches to PEAR-DOC once I get the official word. > > And last (only somewhat related..): > What is the proper channel to obtain PEAR-DOC karma? I know docbook well > enough that I won't screw it up -- I'm active on phpdoc. Should I just > submit patches for the next while, and worry about this later? I'd ask > systems@ directly, but I'd need someone respectable to vouch. > > Thanks, > S > -- Justin Patrin