Re: Re: cvs: pear /Mail_Mime mime.php

Sean Coates wrote:

Hello, QA. First was: true and false should be lowercase, not uppercase.

You are kind of right - they should probably technically be uppercase * the example in the manual (sample file) illustrates them with lowercase * I think if you look at the 1000+ files in CVS, it's pretty consistantly done that way. It really does need documenting however.. to make it clearer - as it's a pretty widely accepted standard now.

* Ditch the parentheses around the requires.

The manual is also unclear on this. Is this necessary? What is "proper"? I'll send a patches to PEAR-DOC once I get the official word. "Note: include_once() and require_once() are statements, not functions. You don't need parentheses around the filename to be included."

Although it's not been totally enforced ( a down and dirty grep showed ~800 uses of () out of ~3400) Come and appreciate the beauty :) Regards Alan

Thanks, S