Re: private methods require an underscore
| From: | Christian Weiske | Date: | Sun, 25 Nov 2007 09:11:18 +0000 |
| Subject: | Re: private methods require an underscore | ||
| References: | 1 2 3 | Groups: | php.pear.qa |
| Request: | Send a blank email to pear-qa+get-4609@lists.php.net to get a copy of this message | ||
Till and Greg,
The manual states:
> PHP does not yet support truly-enforceable private namespaces
The PEAR CS were written when PHP5 did not exist. The above statement
is wrong now, PHP5 does support visibility modificators.
So in my eyes, PHPCS should not tell that private method need to be
prefixed in PHP versions that "support truly-enforceable private
namespaces" - which is php5.
> > And as always, before the PEAR standard in PHP_CodeSniffer could be
> > changed, the written PEAR standard would need to be changed.
>
> OK, wasn't aware of all that. Well, I think this would need to be
> "adjusted". :) How does one go about it? Like the formal process...
We're currently collecting things that need to be changed, see
http://wiki.pear.php.net/index.php/CodingStandardsChanges
And add your own changes.
--
Regards/Mit freundlichen Grüßen
Christian Weiske
Attachment: [application/pgp-signature] signature.asc
Attachment: [application/pgp-signature] signature.asc