Re: private methods require an underscore
| From: | Greg Sherwood | Date: | Sun, 25 Nov 2007 09:21:11 +0000 |
| Subject: | Re: private methods require an underscore | ||
| References: | 1 2 3 4 | Groups: | php.pear.qa |
| Request: | Send a blank email to pear-qa+get-4610@lists.php.net to get a copy of this message | ||
Christian Weiske wrote:
The manual states:GregPHP does not yet support truly-enforceable private namespacesThe PEAR CS were written when PHP5 did not exist. The above statement is wrong now, PHP5 does support visibility modificators. So in my eyes, PHPCS should not tell that private method need to be prefixed in PHP versions that "support truly-enforceable private namespaces" - which is php5. I just try to enforce the documented coding standards because I shouldn't be deciding what is right and wrong with them. If PEAR decides that private methods no longer need underscores in PHP5 scripts, I'll be happy to make the change to PHP_CodeSniffer.