Re: Re: Testing of Net_FTP 1.3.3
| From: | Jorrit Schippers - nCode | Date: | Sun, 02 Dec 2007 12:50:46 +0000 |
| Subject: | Re: Re: Testing of Net_FTP 1.3.3 | ||
| References: | 1 2 3 | Groups: | php.pear.qa |
| Request: | Send a blank email to pear-qa+get-4663@lists.php.net to get a copy of this message | ||
On Sun, 2 Dec 2007 09:41:27 +0100, cweiske@cweiske.de (Christian
Weiske) wrote:
>Jorrit,
>
>
>> I have updated the file
>> http://www.ncode.nl/files/Net_FTP-1.3.3.tgz
>> to include the suggested fixes (except making an RC, I hope this will
>> be the last tryout version anyway)
>Btw, if you still want you could fix the cs errors in Socket.php - the
>other files are amazingly cs-errorfree :)
Socket.php is not used anywhere, and I was thinking about leaving it
out actually... But on the other hand, someone might use it, so I've
made it as CS compliant as possible: one error can't be fixed, namely
this one:
Function name "ftp_alloc" is prefixed with a package name but does not
begin with a capital letter
As you can imagine, fixing this bug would remove the use of the file.
I don't know how to prevent it, so I just left it this way.
The package has been updated with the changes.
Jorrit