Re: Image_Barcode maintainer request

Hi Christian, >> > The first patch is fine, the second is not - as I wrote to in the >> > comment. Please provide a better one. If you have some more >> > patches, we'll be happy to review them. >> >> I've attached a revised patch for Request #10594. > I see you did not test the patch at all, otherwise you would have seen > that it does not work. That's a bad start I would say. yeah, I didn't test in PHP4, just 5. It is embarrassingly not a good start. This re-affirms the importance of testing for me. > Do you know about unit testing (phpt or phpunit)? I'd like to see some > tests for the draw() method - start with the current, unpatched code. > If you apply your current revised patch, you will see that the test > breaks. Then you should supply a better, working patch. I will do some unit testing and submit the tests and fix the patch. I'll email once I've done it. >> I've been wanting to add a couple of features to this package in the >> future; such as: being able to specify the dimensions of the barcodes, >> but have not yet gotten around to it. I wanted to start with fixing >> bugs. > That's generally a good idea :) > Would it be ok for you if I applied that one working patch? Yes, that's ok with me. Thanks, Adrian Mugica