Re: Image_Barcode maintainer request

From: Date: Thu, 28 Jan 2010 07:31:12 +0000
Subject: Re: Image_Barcode maintainer request
References: 1 2 3 4 5 6 7 8 9 10  Groups: php.pear.qa 
Request: Send a blank email to pear-qa+get-5577@lists.php.net to get a copy of this message
Hello Adrian > >> I've attached a revised patch for Request #10594. > > I see you did not test the patch at all, otherwise you would have > > seen that it does not work. That's a bad start I would say. > yeah, I didn't test in PHP4, just 5. It is embarrassingly not a good > start. This re-affirms the importance of testing for me. It did not even work in PHP5 anymore, since there was no image returned at all with your patch. > I will do some unit testing and submit the tests and fix the patch. > I'll email once I've done it. We're always there to help - if there is any problem or thing you don't understand or liked to know, ask pear-dev@lists.php.net or join us in #pear on efnet IRC. -- Regards/Mit freundlichen Grüßen Christian Weiske -=≡ Geeking around in the name of science since 1982 ≡=-

Attachment: [application/pgp-signature] signature.asc
« previous php.pear.qa (#5577) next »