#1319 [Opn->Csd]: PATCH fix styles for manual navigation
| From: | mj@php.net | Date: | Sat, 01 May 2004 20:55:56 +0000 |
| Subject: | #1319 [Opn->Csd]: PATCH fix styles for manual navigation | ||
| References: | 1 | Groups: | php.pear.webmaster |
| Request: | Send a blank email to pear-webmaster+get-2198@lists.php.net to get a copy of this message | ||
ID: 1319
Updated by: mj@php.net
Reported By: danielc at analysisandsolutions dot com
-Status: Open
+Status: Closed
Bug Type: Web Site
Operating System: Irrelevant
PHP Version: Irrelevant
New Comment:
Commited.
I changed the absolute font sizes to relative ones and additionally I
also "cleaned up" the stylesheet a bit.
Previous Comments:
------------------------------------------------------------------------
[2004-05-01 16:09:40] danielc at analysisandsolutions dot com
Helgi, please provide a citation regarding "pt" in CSS being meant for
printed matter. It's not mentioned in the CSS 1 recommendation, that's
for sure.
When fixed size fonts are needed (as I believe they are in this case),
pt is the way to go because they are more consistently rendered than
px.
Martin, even though I'm arguing for pt, it's not THAT big a deal. Just
apply the patch with the existing 8pt or substituting 75% and I'll be
happy.
Thanks.
------------------------------------------------------------------------
[2004-04-30 23:47:06] helgi at trance dot is
Well one should never use pt on web since those are mostly only ment
for printing ;)
------------------------------------------------------------------------
[2004-04-30 13:17:42] danielc at analysisandsolutions dot com
In general I agree with you about absolute font sizes. The reason
they're acceptable in this situation is the text in question is just
the navigation stuff (previous/next and language links, etc) which
isn't really meant to be read.
Also, the fixed size comes in handy here because the existing style
sheets already set the body font to a relative size. If that size gets
changed at some future time, it would impact how the navigation lays
out. This already happened once recently.
If you disagree, please change "8pt" to "75%" in style-manual.css and
then apply it.
Thanks.
------------------------------------------------------------------------
[2004-04-30 12:51:02] mj@php.net
Absolute font sizes are definitively no nice thing. Can you get rid of
them and use relative sizes instead?
------------------------------------------------------------------------
[2004-04-30 11:13:51] danielc at analysisandsolutions dot com
Description:
------------
The navigation bar for the manual needs better formatting to reduce the
number of times it becomes so wide that it forces the body text off the
right hand side of the page.
Also, there needs to be an easy way to add style sheets to the
<header>. I've added the $extra_styles array for this purpose.
Here's the patch
http://www.analysisandsolutions.com/pear/manual.nav.style.diff
------------------------------------------------------------------------
--
Edit this bug report at http://pear.php.net/bugs/bug.php?id=1319&edit=1