Re: [pear-webmaster] Re: [PEAR-CVS] cvs: pearweb /public_html/bugs search.php

On Wed, 2004-06-30 at 01:07, Daniel Convissor wrote: > Hi Helgi: > > > @@ -218,7 +218,20 @@ > > $search_site = ''; > > } else { > > $search_site = $site; > > - $where_clause .= " AND packages.package_type = > > '".escapeSQL($search_site)."'"; > > + if (in_array('Bug System', $_GET['package_name'])) { > > + $pseudo[] = 'Bug System'; > > + } > > ... snip ... > > > + $where_clause .= " AND packages.package_type = > '".escapeSQL($search_site)."' > > + OR bugdb.package_name IN ('".join("', > > '", > escapeSQL($pseudo)) . "')"; > > > Without taking a close look, this approach looks very weird. The system > worked fine for pseudo packages before. This stuff is a hack. That I know, this came because I only allowed packages with package_type of X (defined in prepend.inc) and well since Web Site and that like aren't really in the system this had to be done. Unless we want to have pecl bug in our search results again. So really the pick is, this hack or have pecl bugs again in the search results. I choose the first one :) I like to know how many bugs we have for real ;)