Re: Re: cvs: php4 /pear/Cache/Container db.php phplib.php
| From: | Ulf Wendel | Date: | Fri, 02 Mar 2001 15:38:32 +0000 |
| Subject: | Re: Re: cvs: php4 /pear/Cache/Container db.php phplib.php | ||
| References: | 1 2 | Groups: | php.pear |
| Request: | Send a blank email to php-pear+get-1550@lists.php.net to get a copy of this message | ||
Jon Parise schrieb:
>
> On Fri, Mar 02, 2001 at 02:16:38PM -0000, Ulf Wendel wrote:
>
> > + /**
> > + * Stores a dataset.
> > + *
> > + * WARNING: we use the SQL command REPLACE INTO this might be
> > + * MySQL specific. As MySQL is very popular the method should
> > + * work fine for 95% of you.
> > + */
> > function save($id, $data, $expires = 0)
> > {
> > $query = sprintf('REPLACE INTO %s (content, expires, id) VALUES (%s, %d,
> > %s)',
>
> It's nice that you've added this warning, but it still makes this code
> MySQL-specific (it won't work with PostgreSQL and perhaps other
> database).
Where I don't really care about as I won't write slow code to 95% of the
users. No, I will not commit any changes to this. It's not really hard
for the few non MySQL users to change this line. There's a clear warning
in the online docs.
> Ref:
> http://www.postgresql.org/mhonarc/pgsql-general/1999-10/msg00045.html
I'm not intrested in a discussion on the pro and con of MySQL or any
other database system. This has nothing to do with the code.
Ulf
--
Ulf Wendel, NetUSE AG Siemenswall, D-24107 Kiel
Tel: +49 431 386 436 00, Fax: +49 431 386 435 99