Re: Re: cvs: php4 /pear DB.php /pear/DB common.phpmysql.php

Sebastian Bergmann wrote: > > "Stig S. Bakken" wrote: > > Why can't DB_mysql just create the table if it has create privileges? > > The less installation hassle the better. > > Tell me how and I'll do it. First of all, I think we should be careful about adding features to DB that are not portable by concept. Table locking is not. AFAIK MySQL is the only DBMS that actually implements locking as such, others have similar functionality through transactions. Anyway, you don't need table locking for this. I've implemented a suggestion in CVS. By the way, when you work on code that other people have written and has an interest in still maintaining, the rule "if it works, don't fix it" applies more than ever. This certainly goes for indentation as well. Just changing everything like you did is rude, and I want to ask that you please refrain from doing changes like that in the future without even discussing it on the list first. All you accomplish is to piss someone off. - Stig