Re: New extension php-apn
| From: | Johannes Schlüter | Date: | Wed, 29 May 2013 08:32:11 +0000 |
| Subject: | Re: New extension php-apn | ||
| References: | 1 2 3 | Groups: | php.pecl.dev |
| Request: | Send a blank email to pecl-dev+get-10705@lists.php.net to get a copy of this message | ||
Hi,
On Tue, 2013-05-28 at 18:11 +0700, Anton Dobkin wrote:
> > The code was a it too much for a review right now, the only thing I
> > noticed while scrolling over the file was the zend_parse_parameters
> > return
> >
> > https://wiki.php.net/internals/review_comments#if_zend_parse_parameters_fails_do_a_simple_return
>
> I fixed it
:-)
I see you've requested an VCS account. Do you want to host the
repository on git.php.net (mirrored to github/php/)? By which name? - We
prefix repo names by category, maybe pecl-networking-apn.git?
johannes