Re: Extension proposal: dom_varimport

Thanks! Fixed: https://github.com/DmitryKoterov/dom_varimport/blob/master/dom_varimport.c#L66 Now if somebody e.g. tries to run dl('dom_varimport.so') when "dom" extension is not loaded, PHP throws an error. Run-time module dependency. Good. On Wed, Apr 23, 2014 at 12:05 AM, Alexey Zakhlestin <indeyets@gmail.com>wrote: > > On 22 Apr 2014, at 23:02, Dmitry Koterov <dmitry.koterov@gmail.com> wrote: > > > Johannes, > > > > Thanks a lot, I modified the extension carefully according to all of your > > notes. Everything has been covered by tests, here they are: > > > > https://github.com/DmitryKoterov/dom_varimport/tree/master/tests > > > > About your note "You should add the dom extension as dependency in the > > module structure, this can improve error messages in some cases when > using > > shared libraries ...". I thought that THERE IS the dependency declared, > see > > > > https://github.com/DmitryKoterov/dom_varimport/blob/master/config.m4#L25. > > I also added DOM extension dependency directly to PHPT tests as well - > > please see e.g. > > > > https://github.com/DmitryKoterov/dom_varimport/blob/master/tests/002_formats.phpt#L6 > > > > Maybe you've meant some other dependencies? How to declare them? I > googled, > > but I failed. > > Hi Dmitry, > > you talk about compile-time dependency, and Johannes talks about run-time > dependency. > something like this: > > https://github.com/php/php-src/blob/master/ext/pdo_mysql/pdo_mysql.c#L225 > > > -- > Alexey Zakhlestin > CTO at Grids.by/you > https://github.com/indeyets > PGP key: http://indeyets.ru/alexey.zakhlestin.pgp.asc > > > >