Re: Extension proposal: dom_varimport
| From: | Dmitry Koterov | Date: | Wed, 23 Apr 2014 22:12:03 +0000 |
| Subject: | Re: Extension proposal: dom_varimport | ||
| References: | 1 2 3 4 5 6 7 8 9 10 | Groups: | php.pecl.dev |
| Request: | Send a blank email to pecl-dev+get-11783@lists.php.net to get a copy of this message | ||
>
> > So am I right that there is no chance to make more-or-less standard "make
> > test" work in this case? I suppose that "make test" is a standard step
> that
> > is performed by a typical user of a PECL extension... People will be
> > confused if plain "make test" does not work.
>
> It is not fully reliable. Unfortunately. run-test mostly assumes that
> people use static extensions, as that's what most core developers do.
> The whole module dependency story is a bit weak ... but a very complex
> subject nobody invested time in recently.
>
I learned run-tests.php a bit. I saw a lot of logic to work with dynamic
extensions as well in the script. I suppose, I know how to fix
run-tests.php to eliminate warnings on dependent extension loading.
==========================================
Before the line:
https://github.com/php/php-src/blob/master/run-tests.php#L264
add the following line:
unset($info_params['extension']);
==========================================
- this solves the problem. This simple line turns off loading of extension
which were passed via command-line to run-tests.php (as "-d extension=zzz")
ONLY during the "PHP Info" stage (this stage is just to show something
extension-independent at the screen, it does not affect on the following
tests runs; at the same time, real tests execution code rely on
"--EXTENSIONS--" section in phpt files which is processed by run-tests.php
correctly, e.g.
https://github.com/DmitryKoterov/dom_varimport/blob/master/tests/002_formats.phpt#L5).
How do you think, do I have a chance to push this change into the official
PHP repo?